-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/0.2.0 #103
Feature/0.2.0 #103
Conversation
Are we returning pandas dfs across the board now? |
We are returning pydantic models, which usually contain a dataframe that is validated with pandera. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, I really appreciate the data structure and the setup, it is neat!
I might have appreciated a datetime format rather than string dates (datetime.datetime.strptime(data.period["Tidsperiod (fr.o.m)"][0],"%Y-%m-%d %H:%M:%S"
), but we can leave that parsing for the parent class, if needed.
Again, awesome!
Could you point to where in the code? If it is |
I mean in the |
Let's think about it, as Strang has those fields too. |
Description
Work towards to 0.2.0